Get Package Share vs findPackageShare

`launch_ros.substitutions.FindPackageShare` and 
`ament_index_python.packages.get_package_share_directory`

FindPackageShare uses get_package_share_directory. 
But I would recommend `FindPackageShare` as this is the maintained one implemented for the substitutions.
Motronky